CPS Community Contributors Review Process

CPS Community Contributors Review Process

General Information

Community contributors are managed by selected team members from the CPS project

  1. Deutsche Telekom (TechMahindra) - @Lee Anjella Macabuhay 

Code review process

In order for the CPS team to regularly review the code commits from external contributors the following process. 

  1. Members of the community shall submit their code as work in progress (WIP) initially on Gerrit and add [INTERNAL REVIEW] on items that are still being reviewed by their team.

  2. Always do a self-review first and use the CPS Code Review Check List to minimize the number of peer review iterations required!

  3. There must be at least 2 (two) +1's from community team before this tag is removed.

  4. Once the tag ‘INTERNAL REVIEW’ is removed and set to active, then selected team members from CPS can review the code. 

  5. Code can only be merged once it obtains 3 (three) +1’s from CPS team members.

 

Relevant tools

  1. Slack - slack channel is used to coordinate between the community and the CPS team members regarding the code reviews.

    1. Contact @Lee Anjella Macabuhay  to be added.