References
CPS-2293 - Getting issue details... STATUS
Issues & Decisions
NCMP
Package | Notes of packages which should not be there | Classes from illegal package | Decision | |
|---|---|---|---|---|
| 1 |
| org.onap.cps.spi, | ConditionProperties ModuleDefinition ModuleReference DataNode CpsException DataNodeNotFoundException AlreadyDefinedException CpsException DataValidationException | CPS Utils can be used everywhere in the project |
| 2 | org.onap.cps.ncmp.impl | NetworkCmProxyFacade LockReasonCategory.LOCKED_MISBEHAVING | ||
| 3 |
| org.onap.cps.ncmp.impl | CmHandleQueryService CmHandleRegistrationService InventoryPersistence ParameterizedCmHandleQueryService CmHandleQueryConditions InventoryQueryConditions YangModelCmHandle TrustLevelManager AlternateIdMatcher YangDataConverter | |
| 4 | org.onap.cps.ncmp.config, | CpsApplicationContext | ||
| 5 | org.onap.cps.spi | ModuleDefinition ModuleReference | ||
| 6 |
| org.onap.cps.cpspath | CpsPathUtil CpsPathUtil |
|
| 7 | org.onap.cps.events | EventsPublisher | ||
| 8 | org.onap.cps.impl* | CpsValidator | ||
| 9 | org.onap.cps.spi | DataNode FetchDescendantsOption DataValidationException ModuleDefinition ModuleReference DataNode CpsException DataNodeNotFoundException AlreadyDefinedException CpsException |
CPS
Package | Notes of packages which should not be there | Classes from illegal package | Decision | |
|---|---|---|---|---|
| 1 |
| org.onap.cps.spi | Anchor Dataspace SchemaSet CascadeDeleteAllowed PaginationOption DeltaReport FetchDescendantsOption AlreadyDefinedException CpsAdminException CpsException CpsPathException DataInUseException DataNodeNotFoundException DataValidationException ModelValidationException NotFoundInDataspaceException ModelValidationException | |
| 2 |
| All impl should be moved out odfthe api package, so in my opinion all of these are breaking the Arch rule org.onap.cps.api, org.onap.cps.api.impl, org.onap.cps.events, org.onap.cps.impl.utils, org.onap.cps.spi, org.onap.cps.utils, org.onap.cps.cpspath.parser, org.onap.cps.yang | See the comment on the left. The possible list of classes would be numerous, so I’m not detailing them. |