Skip to end of metadata
Go to start of metadata

You are viewing an old version of this content. View the current version.

Compare with Current View Version History

Version 1 Next »

This page is not intended to include a comprehensive list of everything that should be checked during a code review for CPS. Instead it attempt to list to less well known or very often (forgotten) rules that we should apply in CPS to keep the high quality of our production and test code.

Simple is Good, Complex is Bad

There is one simple rules that applies to all code and can often be used to decide between several coding solutions:


Common Mishaps

#DescriptionBadGood
1Overuse of constant for String Literals (that don't add value)
Also duplication is not a good reason, it often 'smells like' a method that should be extracted out instead

final static String HELLO = "Hello ";
String message = HELLO + name;

String message = "Hello " + name;

2Avoid using ! when else block is implemented 

if (x!=null) { do something } else { report error }

if (x==null) { report error } else { do something }
3No need for else after return statement

if (x==true) {
   return something;
} else {
   return something-else;

if (x==true) {
  return something;
}
return something-else;
  • No labels