| Status | Choose One: DRAFT |
|---|---|
| Submitter | Rabi Abdel (Vodafone) |
| Contributors | China Mobile – Yan Yang: yangyanyj@chinamobile.com Huawei - Victor Gao: victor.gao@huawei.com Huawei - Kanag Manickam: kanagaraj.manickam@huawei.com Intel – Haibin Huang: haibin.huang@intel.com |
| Proposed Release | Frankfurt Release |
| JIRA Ticket(s) | SDC-2482 - Getting issue details... STATUS |
Overview
This is an expansion to a previous contribution made for Dublin Release (VSP Compliance Check within SDC (Dublin) - Phase 1)
Abstract
This proposal is to add dynamic checks within SDC to invoke VTP to run compliance and validation tests against VSP (VNF) prior accepting the VSP (VNF).
Rationale
Please refer to: VSP Compliance Check within SDC (Dublin) - Phase 1
Other Options Considered
Please refer to: VSP Compliance Check within SDC (Dublin) - Phase 1
Code Structure
ONAP code can be found in: https://git.onap.org/
This feature impacts SDC code in two areas: openecomp-be and openecomp-ui. "openecomp-be" provides APIs and functionality to support the SDC user interface. "openecomp-ui" contains the react-based user interface.
Back-end Code Impacts
The back-end code is broken down into four layers - api, backend, lib and tools.
API Layer changes
The "api" layer defines the client facing REST APIs that are consumed by the front end. This feature includes additions to the api for "external" testing interfaces. There are internal validations in SDC to validate CSAR and HEAT content. The classes and packages are named with "external" in the name since this functionality is implemented external to SDC in VTP and OPNFV. These front-end APIs provide an interface to access and perform these tests in components external to SDC.
The code in the API layer is organized by page / function on the user interface. This makes adding new functionality fairly isolated from the existing code. A new package called externaltesting-rest in openecomp-sdc-rest-webapp has been added for this feature. A Java interface which defines the REST endpoints and implementation of that interface were created. The implementation simply delegates to a "lib" layer function to perform the operations.
To enable the new client-facing REST APIs, the beans-services.xml file in openecomp-sdc-rest-webapp/onboarding-rest-war was modified. This modification causes the external testing manager (see lib changes below) to be instantiated during application startup.
Lib Layer changes
The "lib" layer provides the functionality used in api layer. This layer implements REST calls to external testing resources including VTP and OPNFV (when available).
Like the API layer, functionality is broken down into separate sub-projects within the "lib" layer. A new sub-project called openecomp-sdc-externaltesting-lib was created for this feature. Under this project are api classes and implementation classes in the openecomp-sdc-externaltesting-api and openecomp-sdc-externaltesting-impl directories respectively.
Internal library dependencies
This new openecomp-sdc-externaltesting-lib library has dependencies on other internal library level functionality. This library uses both the vendorsoftwareproduct and versioning libraries to retrieve CSAR artifacts in order to extract metadata to enable external testing.
External library dependencies
No additional 3rd party open source libraries were added to implement this feature.
Front-end Code Impacts
Proposal
From a high-level perspective, the proposal will allow VSP, when uploaded into SDC, to go through a set of checks to make sure it is compliant to the deployment environment and custom requirements.
Those checks can be done during the VSP validation stage by implementing plug-ins to SDC and introducing both a "certification repository" and a testing framework to be consulted. Figure 1 shows the proposal in a high-level view.
Figure 1: High-Level proposal.
E2E Strategy (integration within SDC)
Impacts & Planning:
https://wiki.lfnetworking.org/display/LN/TOSCA+VNF+Validation+Planning
References
VTP New API changes for this feature
VSP Compliance Check within SDC - Integration Test Plan
VSP Compliance Check within SDC - Integration Test Result
CSIT Test Result
Test Case ID | · TEST-CASE-1 | |||||||||||||||
Test Case Name | Validation Result page | |||||||||||||||
Description | When there is no test case executed then the “Validation Result” page shown with default Message “No Test Performed” | |||||||||||||||
Release | Frankfurt | |||||||||||||||
Preconditions | · Local SDC or ONAP deployment available and running; · A SDC VSP should be created; · VTP Server should be configured and enabled | |||||||||||||||
Testing Steps |
| |||||||||||||||
Status (Pass/Fail) | Validation Result Page: COMPLETE | |||||||||||||||
Testing Lab | Local SDC deployment |
Test Case ID | · TEST-CASE-2 | |||||||||||||||||||||
Test Case Name | Execute Validation Test Case with Result | |||||||||||||||||||||
Description | Validation test case by loading the vendor provided corresponding CSAR(s) and required input(s) and result displaying in the Validation Result page | |||||||||||||||||||||
Release | Frankfurt | |||||||||||||||||||||
Preconditions | · Local SDC or ONAP deployment available and running; · A SDC VSP should be created; · VTP Server should be configured and enabled | |||||||||||||||||||||
Testing Steps |
| |||||||||||||||||||||
Status (Pass/Fail) | Validation Result Page: COMPLETE Used package: vsp-vgw.csar CSIT build: https://jenkins.onap.org/view/sdc/job/sdc-master-csit-sanity-testng/2245/ | |||||||||||||||||||||
Testing Lab | Local SDC deployment |
Demo
VSP Compliance Checks Demo VOICE NARRATEDv2 Tuesday, April 02, 2019 1.39.34 PM.mp4