Versions Compared

Version Old Version 4 New Version 5
Changes made by

Levente Csanyi

Levente Csanyi

Saved on

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

23

Package

Notes of packages which should not  be there

Classes from illegal package

Decision

1

org.onap.cps.ncmp.rest

Code Block
org.onap.cps.spi,
org.onap.cps.utils,
Code Block
ConditionProperties
ModuleDefinition
ModuleReference
DataNode
CpsException
DataNodeNotFoundException
AlreadyDefinedException
CpsException
DataValidationException

CPS Utils can be used everywhere in the project

2
Code Block
org.onap.cps.ncmp.impl
 Code Block
NetworkCmProxyFacade
LockReasonCategory.LOCKED_MISBEHAVING
3
org.onap.cps.ncmp.api
 Code Block
org.onap.cps.ncmp.api,
org.onap.cps.ncmp.impl,
impl
 Code Block
CmHandleQueryService
CmHandleRegistrationService
InventoryPersistence
ParameterizedCmHandleQueryService
CmHandleQueryConditions
InventoryQueryConditions
YangModelCmHandle
TrustLevelManager
AlternateIdMatcher
YangDataConverter
4
 Code Block
org.onap.cps.ncmp.config,

 Code Block
CpsApplicationContext
5
 Code Block
org.onap.cps.spi,
org.onap.cps.utils
 Code Block
ModuleDefinition
ModuleReference
6
org.onap.cps.ncmp.impl
 Code Block
org.onap.cps.cpspath,
org
 Code Block
CpsPathUtil
CpsPathUtil
org/onap/cps/impl/utils/CpsValidator.java should be moved to org/onap/cps/utils
7
 Code Block
org.onap.cps.events,

 Code Block
EventsPublisher
8
 Code Block
org.onap.cps.impl,
*
 Code Block
CpsValidator
9
 Code Block
org.onap.cps.spi,
org.onap.cps.utils
 Code Block
DataNode
FetchDescendantsOption
DataValidationException
ModuleDefinition
ModuleReference
DataNode
CpsException
DataNodeNotFoundException
AlreadyDefinedException
CpsException
CPS
Package
Notes of packages which should not  be there
Classes from illegal package
Decision
1
org.onap.cps.rest.
 Code Block
org.onap.cps.spi
 Code Block
Anchor
Dataspace
SchemaSet
CascadeDeleteAllowed
PaginationOption
DeltaReport
FetchDescendantsOption
AlreadyDefinedException
CpsAdminException
CpsException
CpsPathException
DataInUseException
DataNodeNotFoundException
DataValidationException
ModelValidationException
NotFoundInDataspaceException
ModelValidationException
2
org.onap.cps.api.impl
All impl should be moved out od the odfthe api package, so in my opinion all of these are breaking the Arch rule
 Code Block
org.onap.cps.api,
org.onap.cps.api.impl,
org.onap.cps.events,
org.onap.cps.impl.utils,
org.onap.cps.spi,
org.onap.cps.utils,
org.onap.cps.cpspath.parser,
org.onap.cps.yang
See the comment on the left. The possible list of classes would be numerous, so I’m not detailing them.