CPS-503 Spike: Investigate Liquibase self-build option

CPS-503: Spike: Investigate Liquibase self-build optionClosed

Purpose of spike

Because of license issues with Liquibase core we need to investigate building liquibase-core from open source Apacahe-2.0 sources ourselves.

see also this mail snippet from Steve Winslow:

"At the community discussion form post that I linked to below, https://forum.liquibase.org/t/licensing-questions-for-community-distro/5617/3, someone from the Liquibase team (I believe one of the primary authors) responded to my question there. They indicated that the built components they offer do contain both Apache-2.0 and proprietary code, and didn't appear to indicate that they could be redistributed due to the presence of the latter. Because of this, they indicated that if ONAP wants to have an open source / Apache-2.0 only version, we would need to build it from the Liquibase Apache-2.0 sources ourselves."

Assumptions

Open Issues & Decisions

#	Issue	Answer/Resolution	Notes/Images

#	Issue	Answer/Resolution	Notes/Images
1	After adding files there are 2,300 checkstyle violation	After conversation with @Toine Siebelinkwe are to ignore violations and proceed to see if it is a viable option	Open
2	Was using latest codebase from GitHub but should be aligned with @Andrew Fenner	I am in contact with @Andrew Fennerto ensure that we are both testing with the same release version - We have decided to go with v4.4.2 (https://github.com/liquibase/liquibase/releases)

Approaches

1. Explore option to automatically copy an build using a Nordix Repo and C/I job. Some technical and legal issues to be examined. Will the delivered artifact(s) be available to non-Nordix users ie. what repo will be used?

2. Create CPS sub-repo with copy of sources from https://github.com/liquibase/liquibase  (legal option, but not easy to share with others) Later even a new shared stand-alone repo? (two-step approach) (Appears to be the quickest and most efficient way to add liquibase to code base)

3. Consider DB-Migrator tool already used and part of ONAP: https://docs.onap.org/projects/onap-policy-parent/en/guilin/drools/pdpdEngine.html#data-migration

4. Consider FlyWay https://dzone.com/articles/flyway-vs-liquibase

Point #1

@Andrew Fenneris investigating this.

liquibase-core has been manually added to Nordix Artifactory (automation pending): https://artifactory.nordix.org/ui/repos/tree/General/liquibase%2Forg%2Fliquibase%2Fliquibase-core%2F4.4.2-nordix%2Fliquibase-core-4.4.2-nordix.jar

• Add new dependencies to cps-ri & cps-depenencies poms

• Build CPS

• Ensure seed data is present in Postgres

Liquibase Console Ouput

Point #2

• Clone liquibase code from GitHub: https://github.com/liquibase/liquibase

• Create new module in CPS (e.g. cps-liquibase)

• Add necessary code to new module

• Build liquibase with CPS & ensure DB steps are carried out

Point #3

TBD

Point #4

@Former user (Deleted) will investigate this.

Conclusions

Point #1 has been tested and is working as expected.