Committer's weekly meeting report - 02/17/2021
Date Feb 17, 2021
Meeting Logistics
Day | Time | Meeting ID | Zoom Link |
Monday | [sdc] Team ONAP3, Mon UTC 10:00 / China 18:00 / Eastern 5:00 / Pacific 02:00 | see list | see ONAP-Meeting invite |
Meeting Attendees
@ChrisC
@Vasyl Razinkov
@Sebastien Determe
@Xue Gao
Tali Orenbach
Agenda & Minutes
Review open action items from last week
Main purpose is to sync between Committers and discuss open reviews, other topics below
Open Reviews :
Agenda | Minutes |
Check on pending Reviews | Any urgent pending reviews ? lots of pending review, need to rebase and review code for merge, pls pay attention : JUNIT version make sure tests are added (we are low on coverage) Dependency version must be up to date(TSC must have) Vasyl asks to review IN/OUT reviews, part 3 will contain tests Discussed several review - Topic : SONAR bugs and coverage, SDC code is not pretty (to say the least) we should remind the community to improve it - do a reminder of the rules (enable checkstyle, sonar checks in IDE) - agree on common rules, maybe enforce them in verify job/add a sonar job in review to catch newly introduced issues quickly - assign resolution to originator of issue since Sept, SDC grow to 145 SONAR bugs AP : Chris to setup a weekly item on items - Done Vote on Code style proposal → done Improve coverage by gathering Integration Test coverage → blocked due to jacoco issue, still at 54.4% Amir's review, assigned to Julien - Done Seb raised the issue that Log4J 1.2 still identified by NExus IQ as a dependency in Catalog-BE and FE (Chris to look at it) - Fixed by Vasyl |
Split verify job in 2 | speed up results by splitting integration phase and unit test/build create new keyword for retest all or only one vote +1 if both are ok mvn clean install -P skip-integration-tests mvn clean install -DskipTests -DskipUICleanup=true -Djacoco.skip=true -DskipPMD -Dmaven.test.skip=true -Dcheckstyle.skip -P docker && mvn install -P start-sdc && mvn install -P run-integration-tests Done, see new verify Jobs Done for enabling concurrent builds on integration tests Still missing : Keyword to re trigger only one, this seems not possible as reusing JJB templates from LF and Integration that are wrapped together → discussed with Lasse, we could try to experiment on our build but since IT tests are the longest, not sure we will will much and the LF wrapper (the one that provides comment and vote +1 ) is probably not smart enough to cope with only one job being re triggered |