{"type":"doc","content":[{"type":"extension","attrs":{"extensionType":"com.atlassian.confluence.macro.core","extensionKey":"toc","parameters":{"macroParams":{},"macroMetadata":{"macroId":{"value":"ea0ac233-2c04-4f9d-bc89-2b8700ea6391"},"schemaVersion":{"value":"1"},"title":"Table of Contents"}}}},{"type":"paragraph","content":[{"text":"This page is not intended to include a comprehensive list of everything that should be checked during a code review for CPS. Instead it attempt to list to less well known or very often (forgotten) rules that we should apply in CPS to keep the high quality of our production and test code.","type":"text"}]},{"type":"heading","attrs":{"level":2},"content":[{"text":"Security Related Checks","type":"text"}]},{"type":"table","attrs":{"isNumberColumnEnabled":true},"content":[{"type":"tableRow","content":[{"type":"tableHeader","attrs":{"colspan":1,"rowspan":1},"content":[{"type":"paragraph","content":[{"text":"Description ","type":"text","marks":[{"type":"strong"}]}]}]},{"type":"tableHeader","attrs":{"colspan":1,"rowspan":1},"content":[{"type":"paragraph","content":[{"text":"Notes","type":"text","marks":[{"type":"strong"}]}]}]}]},{"type":"tableRow","content":[{"type":"tableCell","attrs":{"colspan":1,"rowspan":1},"content":[{"type":"paragraph","content":[{"text":"Do ","type":"text"},{"text":"not log","type":"text","marks":[{"type":"strong"}]},{"text":" any ","type":"text"},{"text":"user data","type":"text","marks":[{"type":"strong"}]},{"text":" at any log level","type":"text"}]}]},{"type":"tableCell","attrs":{"colspan":1,"rowspan":1},"content":[{"type":"paragraph","content":[{"text":"since we do not know what is in the user data there could also be sensitive information inside it.","type":"text"},{"type":"hardBreak"},{"text":"Be awara of logging objects, make sure the toString() implementation doesn't include user data for that object. So instead maybe just log fields that are well defined and do not contain user data.","type":"text"}]}]}]}]},{"type":"paragraph"},{"type":"heading","attrs":{"level":2},"content":[{"text":"Simple is Good, Complex is Bad","type":"text"}]},{"type":"paragraph","content":[{"text":"There is one simple rules that applies to all code and can often be used to decide between several coding solutions.","type":"text"}]},{"type":"table","content":[{"type":"tableRow","content":[{"type":"tableHeader","attrs":{"colspan":1,"rowspan":1},"content":[{"type":"paragraph","content":[{"text":"Description","type":"text","marks":[{"type":"strong"}]}]}]},{"type":"tableHeader","attrs":{"colspan":1,"rowspan":1},"content":[{"type":"paragraph","content":[{"text":"Bad","type":"text","marks":[{"type":"strong"}]}]}]},{"type":"tableHeader","attrs":{"colspan":1,"rowspan":1},"content":[{"type":"paragraph","content":[{"text":"Good","type":"text","marks":[{"type":"strong"}]}]}]}]},{"type":"tableRow","content":[{"type":"tableCell","attrs":{"colspan":1,"rowspan":1},"content":[{"type":"mediaSingle","attrs":{"layout":"align-start"},"content":[{"type":"media","attrs":{"type":"external","url":"http://lh3.ggpht.com/-ZEP86dSBYcs/U6KT2VJntNI/AAAAAAAAEa0/yKk2l_sgQNo/Slide3_thumb%25255B1%25255D.png?imgmax=800"}}]}]},{"type":"tableCell","attrs":{"colspan":1,"background":"#ffebe6","rowspan":1},"content":[{"type":"paragraph","content":[{"text":"Optional optionalResponseBody = Optional.ofNullable(responseEntity.getBody())","type":"text","marks":[{"type":"code"}]},{"type":"hardBreak"},{"text":".filter(Predicate.not(String::isBlank));","type":"text","marks":[{"type":"code"}]},{"type":"hardBreak"},{"text":"return (optionalResponseBody.isPresent()) ? convert(optionalResponseBody.get())","type":"text","marks":[{"type":"code"}]},{"type":"hardBreak"},{"text":": Collections.emptyList();","type":"text","marks":[{"type":"code"}]}]}]},{"type":"tableCell","attrs":{"colspan":1,"background":"#e3fcef","rowspan":1},"content":[{"type":"paragraph","content":[{"text":"String responseBody = responseEntity.getBody();","type":"text","marks":[{"type":"code"}]},{"type":"hardBreak"},{"text":"if (responseBody == null || responseBody.isBlank()) {","type":"text","marks":[{"type":"code"}]},{"type":"hardBreak"},{"text":" return Collections.emptyList();","type":"text","marks":[{"type":"code"}]},{"type":"hardBreak"},{"text":"}","type":"text","marks":[{"type":"code"}]},{"type":"hardBreak"},{"text":"return convert(responseBody);","type":"text","marks":[{"type":"code"}]}]}]}]}]},{"type":"paragraph"},{"type":"paragraph","content":[{"text":"Common Mishaps","type":"text","marks":[{"type":"textColor","attrs":{"color":"#404040"}}]}]},{"type":"table","attrs":{"layout":"full-width","isNumberColumnEnabled":true,"width":1533.4056},"content":[{"type":"tableRow","content":[{"type":"tableHeader","attrs":{"colspan":1,"rowspan":1,"colwidth":[258.86]},"content":[{"type":"paragraph","content":[{"text":"Description","type":"text","marks":[{"type":"strong"}]}]}]},{"type":"tableHeader","attrs":{"colspan":1,"rowspan":1,"colwidth":[565.15]},"content":[{"type":"paragraph","content":[{"text":"Bad","type":"text","marks":[{"type":"strong"}]}]}]},{"type":"tableHeader","attrs":{"colspan":1,"rowspan":1,"colwidth":[680.74]},"content":[{"type":"paragraph","content":[{"text":"Good","type":"text","marks":[{"type":"strong"}]}]}]}]},{"type":"tableRow","content":[{"type":"tableCell","attrs":{"colspan":1,"rowspan":1,"colwidth":[258.86]},"content":[{"type":"paragraph","content":[{"text":"Don't forget to check the ","type":"text"},{"text":"copyright ","type":"text","marks":[{"type":"strong"}]},{"type":"emoji","attrs":{"id":"1f642","text":"🙂","shortName":":slight_smile:"}},{"type":"hardBreak"},{"text":"(add/modify new calendar year to existing copyright if needed)","type":"text"}]}]},{"type":"tableCell","attrs":{"colspan":1,"background":"#ffebe6","rowspan":1,"colwidth":[565.15]},"content":[{"type":"paragraph","content":[{"text":"* Copyright (C) 2021 Other Company","type":"text","marks":[{"type":"code"}]},{"type":"hardBreak"},{"type":"hardBreak"}]}]},{"type":"tableCell","attrs":{"colspan":1,"background":"#e3fcef","rowspan":1,"colwidth":[680.74]},"content":[{"type":"paragraph","content":[{"text":"* Copyright (C) 2021 Other Company","type":"text","marks":[{"type":"code"}]},{"type":"hardBreak"},{"text":"* Modifications Copyright (C) 2021-2022 Nordix Foundation","type":"text","marks":[{"type":"code"}]}]}]}]},{"type":"tableRow","content":[{"type":"tableCell","attrs":{"colspan":1,"rowspan":1,"colwidth":[258.86]},"content":[{"type":"paragraph","content":[{"text":"Don't forget to check the ","type":"text"},{"text":"commit message structure","type":"text","marks":[{"type":"strong"}]}]}]},{"type":"tableCell","attrs":{"colspan":1,"rowspan":1,"colwidth":[565.15]},"content":[{"type":"paragraph"}]},{"type":"tableCell","attrs":{"colspan":1,"background":"#e3fcef","rowspan":1,"colwidth":[680.74]},"content":[{"type":"paragraph","content":[{"text":"It is following ONAP commit message guidelines: ","type":"text"},{"text":"Commit Messages#CommitStructure","type":"text","marks":[{"type":"link","attrs":{"href":"https://lf-onap.atlassian.net/wiki/spaces/DW/pages/16230087#CommitMessages-CommitStructure"}}]}]}]}]},{"type":"tableRow","content":[{"type":"tableCell","attrs":{"colspan":1,"rowspan":1,"colwidth":[258.86]},"content":[{"type":"paragraph","content":[{"text":"Overuse of constan","type":"text","marks":[{"type":"strong"}]},{"text":"t for string literals (that don't add value)","type":"text"},{"type":"hardBreak"},{"text":"Also duplication is not a good reason, it often 'smells like' a method that should be extracted out instead","type":"text"}]}]},{"type":"tableCell","attrs":{"colspan":1,"background":"#ffebe6","rowspan":1,"colwidth":[565.15]},"content":[{"type":"paragraph","content":[{"text":"final static String HELLO = \"Hello \";","type":"text","marks":[{"type":"code"}]},{"type":"hardBreak"},{"text":"String message = HELLO + name;","type":"text","marks":[{"type":"code"}]}]}]},{"type":"tableCell","attrs":{"colspan":1,"background":"#e3fcef","rowspan":1,"colwidth":[680.74]},"content":[{"type":"paragraph","content":[{"text":"String message = \"Hello \" + name;","type":"text","marks":[{"type":"code"}]}]},{"type":"paragraph","content":[{"text":"String sayHello(final String name) {","type":"text","marks":[{"type":"code"}]},{"type":"hardBreak"},{"text":" return \"Hello \" + name;","type":"text","marks":[{"type":"code"}]},{"type":"hardBreak"},{"text":"}","type":"text","marks":[{"type":"code"}]}]}]}]},{"type":"tableRow","content":[{"type":"tableCell","attrs":{"colspan":1,"rowspan":1,"colwidth":[258.86]},"content":[{"type":"paragraph","content":[{"text":"Avoid using","type":"text"},{"text":" ! when else","type":"text","marks":[{"type":"strong"}]},{"text":" block is implemented ","type":"text"}]}]},{"type":"tableCell","attrs":{"colspan":1,"background":"#ffebe6","rowspan":1,"colwidth":[565.15]},"content":[{"type":"paragraph","content":[{"text":"if (x!=null) {","type":"text","marks":[{"type":"code"}]},{"type":"hardBreak"},{"text":" do something;","type":"text","marks":[{"type":"code"}]},{"type":"hardBreak"},{"text":"} else {","type":"text","marks":[{"type":"code"}]},{"type":"hardBreak"},{"text":" report error;","type":"text","marks":[{"type":"code"}]},{"type":"hardBreak"},{"text":" }","type":"text","marks":[{"type":"code"}]}]}]},{"type":"tableCell","attrs":{"colspan":1,"background":"#e3fcef","rowspan":1,"colwidth":[680.74]},"content":[{"type":"paragraph","content":[{"text":"if (x==null) {","type":"text","marks":[{"type":"code"}]},{"type":"hardBreak"},{"text":" report error;","type":"text","marks":[{"type":"code"}]},{"type":"hardBreak"},{"text":"} else {","type":"text","marks":[{"type":"code"}]},{"type":"hardBreak"},{"text":" do something;","type":"text","marks":[{"type":"code"}]},{"type":"hardBreak"},{"text":"}","type":"text","marks":[{"type":"code"}]}]}]}]},{"type":"tableRow","content":[{"type":"tableCell","attrs":{"colspan":1,"rowspan":1,"colwidth":[258.86]},"content":[{"type":"paragraph","content":[{"text":"No need for ","type":"text"},{"text":"else after return","type":"text","marks":[{"type":"strong"}]},{"text":" statement","type":"text"}]}]},{"type":"tableCell","attrs":{"colspan":1,"background":"#ffebe6","rowspan":1,"colwidth":[565.15]},"content":[{"type":"paragraph","content":[{"text":"if (x==true) {","type":"text","marks":[{"type":"code"}]},{"type":"hardBreak"},{"text":" return something;","type":"text","marks":[{"type":"code"}]},{"type":"hardBreak"},{"text":" } else {","type":"text","marks":[{"type":"code"}]},{"type":"hardBreak"},{"text":" return something-else;","type":"text","marks":[{"type":"code"}]},{"type":"hardBreak"},{"text":"}","type":"text","marks":[{"type":"code"}]}]}]},{"type":"tableCell","attrs":{"colspan":1,"background":"#e3fcef","rowspan":1,"colwidth":[680.74]},"content":[{"type":"paragraph","content":[{"text":"if (x==true) {","type":"text","marks":[{"type":"code"}]},{"type":"hardBreak"},{"text":" return something;","type":"text","marks":[{"type":"code"}]},{"type":"hardBreak"},{"text":" }","type":"text","marks":[{"type":"code"}]},{"type":"hardBreak"},{"text":"return something-else;","type":"text","marks":[{"type":"code"}]}]}]}]},{"type":"tableRow","content":[{"type":"tableCell","attrs":{"colspan":1,"rowspan":1,"colwidth":[258.86]},"content":[{"type":"paragraph","content":[{"text":"No need to check for not ","type":"text"},{"text":"empty before iterating","type":"text","marks":[{"type":"strong"}]},{"text":" on collection","type":"text"}]}]},{"type":"tableCell","attrs":{"colspan":1,"background":"#ffebe6","rowspan":1,"colwidth":[565.15]},"content":[{"type":"paragraph","content":[{"text":"if (!myCollection.isEmpty()) {","type":"text","marks":[{"type":"code"}]},{"type":"hardBreak"},{"text":" collection.forEach(some action);","type":"text","marks":[{"type":"code"}]},{"type":"hardBreak"},{"text":"}","type":"text","marks":[{"type":"code"}]}]}]},{"type":"tableCell","attrs":{"colspan":1,"background":"#e3fcef","rowspan":1,"colwidth":[680.74]},"content":[{"type":"paragraph","content":[{"text":"collection.forEach(some action);","type":"text","marks":[{"type":"code"}]},{"type":"hardBreak"}]}]}]},{"type":"tableRow","content":[{"type":"tableCell","attrs":{"colspan":1,"rowspan":1,"colwidth":[258.86]},"content":[{"type":"paragraph","content":[{"text":"No ","type":"text"},{"text":"unnecessary test data","type":"text","marks":[{"type":"strong"}]},{"text":" ","type":"text"},{"type":"hardBreak"},{"text":"Try to minimize the test data to ","type":"text"},{"text":"just","type":"text","marks":[{"type":"strong"}]},{"text":" the data needed for the use case under test","type":"text"},{"type":"hardBreak"},{"text":"(often test data from other test is copied and pasted into new test that simply don't need it)","type":"text"}]}]},{"type":"tableCell","attrs":{"colspan":1,"background":"#ffebe6","rowspan":1,"colwidth":[565.15]},"content":[{"type":"paragraph","content":[{"text":"def 'Registration with invalid cm handle name'() {","type":"text","marks":[{"type":"code"}]},{"type":"hardBreak"},{"text":"given: 'invalid cm handle name'","type":"text","marks":[{"type":"code"}]},{"type":"hardBreak"},{"text":" cmHandle.id = 'invalid,name'","type":"text","marks":[{"type":"code"}]},{"type":"hardBreak"},{"text":" cmHandle.dmiProperties = [dmiProp1: 'dmiValue1']","type":"text","marks":[{"type":"code"}]},{"type":"hardBreak"},{"text":"when: ...","type":"text","marks":[{"type":"code"}]}]}]},{"type":"tableCell","attrs":{"colspan":1,"background":"#e3fcef","rowspan":1,"colwidth":[680.74]},"content":[{"type":"paragraph","content":[{"text":"def 'Registration with invalid cm handle name'() {","type":"text","marks":[{"type":"code"}]},{"type":"hardBreak"},{"text":"given: 'invalid cm handle name'","type":"text","marks":[{"type":"code"}]},{"type":"hardBreak"},{"text":" cmHandle.id = 'invalid,name'","type":"text","marks":[{"type":"code"}]},{"type":"hardBreak"},{"text":"when: ...","type":"text","marks":[{"type":"code"}]}]}]}]},{"type":"tableRow","content":[{"type":"tableCell","attrs":{"colspan":1,"rowspan":1,"colwidth":[258.86]},"content":[{"type":"paragraph","content":[{"text":"Do ","type":"text"},{"text":"not use 'var'","type":"text","marks":[{"type":"strong"}]},{"text":". Explicitly define object types instead of just using var ","type":"text"}]}]},{"type":"tableCell","attrs":{"colspan":1,"background":"#ffebe6","rowspan":1,"colwidth":[565.15]},"content":[{"type":"paragraph","content":[{"text":"var dataspaceEntity = dataspaceRepository.getByName(dataspaceName);","type":"text","marks":[{"type":"code"}]}]}]},{"type":"tableCell","attrs":{"colspan":1,"background":"#e3fcef","rowspan":1,"colwidth":[680.74]},"content":[{"type":"paragraph","content":[{"text":"DataspaceEntity dataspaceEntity = ","type":"text","marks":[{"type":"code"}]},{"type":"hardBreak"},{"text":"dataspaceRepository.getByName(dataspaceName);","type":"text","marks":[{"type":"code"}]}]}]}]},{"type":"tableRow","content":[{"type":"tableCell","attrs":{"colspan":1,"rowspan":1,"colwidth":[258.86]},"content":[{"type":"paragraph","content":[{"text":"Maven","type":"text","marks":[{"type":"strong"}]},{"text":" dependencies should be defined in ","type":"text"},{"text":"Version Management","type":"text","marks":[{"type":"strong"}]}]},{"type":"paragraph","content":[{"text":"*Note.","type":"text","marks":[{"type":"strong"}]},{"text":" CPS(core) project has a separate ","type":"text"},{"text":"cps-dependencies","type":"text","marks":[{"type":"code"}]},{"text":" module!","type":"text"}]}]},{"type":"tableCell","attrs":{"colspan":1,"background":"#ffebe6","rowspan":1,"colwidth":[565.15]},"content":[{"type":"paragraph","content":[{"text":"","type":"text","marks":[{"type":"code"}]},{"type":"hardBreak"},{"text":" ","type":"text","marks":[{"type":"code"}]},{"type":"hardBreak"},{"text":" net.logstash.logback","type":"text","marks":[{"type":"code"}]},{"type":"hardBreak"},{"text":" logstash-logback-encoder","type":"text","marks":[{"type":"code"}]},{"type":"hardBreak"},{"text":" 7.0.1","type":"text","marks":[{"type":"code"}]},{"type":"hardBreak"},{"text":" ","type":"text","marks":[{"type":"code"}]},{"type":"hardBreak"},{"text":"","type":"text","marks":[{"type":"code"}]}]}]},{"type":"tableCell","attrs":{"colspan":1,"background":"#e3fcef","rowspan":1,"colwidth":[680.74]},"content":[{"type":"paragraph","content":[{"text":"","type":"text","marks":[{"type":"code"}]},{"type":"hardBreak"},{"text":" ","type":"text","marks":[{"type":"code"}]},{"type":"hardBreak"},{"text":" ","type":"text","marks":[{"type":"code"}]},{"type":"hardBreak"},{"text":" net.logstash.logback","type":"text","marks":[{"type":"code"}]},{"type":"hardBreak"},{"text":" logstash-logback-encoder","type":"text","marks":[{"type":"code"}]},{"type":"hardBreak"},{"text":" 7.0.1","type":"text","marks":[{"type":"code"}]},{"type":"hardBreak"},{"text":" ","type":"text","marks":[{"type":"code"}]},{"type":"hardBreak"},{"text":" ","type":"text","marks":[{"type":"code"}]},{"type":"hardBreak"},{"text":"","type":"text","marks":[{"type":"code"}]}]},{"type":"paragraph","content":[{"text":"","type":"text","marks":[{"type":"code"}]},{"type":"hardBreak"},{"text":" ","type":"text","marks":[{"type":"code"}]},{"type":"hardBreak"},{"text":" net.logstash.logback","type":"text","marks":[{"type":"code"}]},{"type":"hardBreak"},{"text":" logstash-logback-encoder","type":"text","marks":[{"type":"code"}]},{"type":"hardBreak"},{"text":" ","type":"text","marks":[{"type":"code"}]},{"type":"hardBreak"},{"text":"","type":"text","marks":[{"type":"code"}]}]}]}]},{"type":"tableRow","content":[{"type":"tableCell","attrs":{"colspan":1,"rowspan":1,"colwidth":[258.86]},"content":[{"type":"paragraph","content":[{"text":"Use ","type":"text"},{"text":"ObjectMapper","type":"text","marks":[{"type":"strong"}]},{"text":"() instead of Gson()","type":"text"},{"type":"hardBreak"},{"text":"See ","type":"text"},{"text":"Spike: Which ObjectMapper ","type":"text","marks":[{"type":"link","attrs":{"href":"https://lf-onap.atlassian.net/wiki/spaces/DW/pages/16488677"}}]}]}]},{"type":"tableCell","attrs":{"colspan":1,"background":"#ffebe6","rowspan":1,"colwidth":[565.15]},"content":[{"type":"paragraph","content":[{"text":"Gson gson = new Gson();","type":"text","marks":[{"type":"code"}]},{"type":"hardBreak"},{"text":"JsonElement jsonElement = gson.fromJson(jsonString, JsonElement.class);","type":"text","marks":[{"type":"code"}]}]}]},{"type":"tableCell","attrs":{"colspan":1,"background":"#e3fcef","rowspan":1,"colwidth":[680.74]},"content":[{"type":"paragraph","content":[{"text":"ObjectMapper mapper = new ObjectMapper();","type":"text","marks":[{"type":"code"}]},{"type":"hardBreak"},{"text":"JsonNode jsonNode = mapper.readTree(jsonString);","type":"text","marks":[{"type":"code"}]}]}]}]},{"type":"tableRow","content":[{"type":"tableCell","attrs":{"colspan":1,"rowspan":1,"colwidth":[258.86]},"content":[{"type":"paragraph","content":[{"text":"Use ","type":"text"},{"text":"String concatenation","type":"text","marks":[{"type":"strong"}]},{"text":" instead of ","type":"text"},{"text":"String.format","type":"text","marks":[{"type":"strong"}]},{"text":" (5x slower!) where possible ","type":"text"}]}]},{"type":"tableCell","attrs":{"colspan":1,"background":"#ffebe6","rowspan":1,"colwidth":[565.15]},"content":[{"type":"paragraph","content":[{"text":"String.","type":"text","marks":[{"type":"code"}]},{"text":"format","type":"text","marks":[{"type":"code"}]},{"text":"(","type":"text","marks":[{"type":"code"}]},{"text":"\"","type":"text","marks":[{"type":"code"}]},{"text":"cm-handle","type":"text","marks":[{"type":"code"}]},{"text":":%s\",cmHandleId);","type":"text","marks":[{"type":"code"}]}]}]},{"type":"tableCell","attrs":{"colspan":1,"background":"#e3fcef","rowspan":1,"colwidth":[680.74]},"content":[{"type":"paragraph","content":[{"text":"\"","type":"text","marks":[{"type":"code"}]},{"text":"cm-handle:","type":"text","marks":[{"type":"code"}]},{"text":"\" + cmHandleId;","type":"text","marks":[{"type":"code"}]}]}]}]},{"type":"tableRow","content":[{"type":"tableCell","attrs":{"colspan":1,"rowspan":1,"colwidth":[258.86]},"content":[{"type":"paragraph","content":[{"text":"Initialize collections/arrays with ","type":"text"},{"text":"known size","type":"text","marks":[{"type":"strong"}]},{"text":" where possible","type":"text"}]}]},{"type":"tableCell","attrs":{"colspan":1,"background":"#ffebe6","rowspan":1,"colwidth":[565.15]},"content":[{"type":"paragraph","content":[{"text":"void processNames(Collection orginalNames) {","type":"text","marks":[{"type":"code"}]},{"type":"hardBreak"},{"text":" String[] processedNames = new String[0];","type":"text","marks":[{"type":"code"}]}]}]},{"type":"tableCell","attrs":{"colspan":1,"background":"#e3fcef","rowspan":1,"colwidth":[680.74]},"content":[{"type":"paragraph","content":[{"text":"void processNames(Collection orginalNames) {","type":"text","marks":[{"type":"code"}]},{"type":"hardBreak"},{"text":" String[] processedNames = new String[orginalNames.size()];","type":"text","marks":[{"type":"code"}]}]}]}]},{"type":"tableRow","content":[{"type":"tableCell","attrs":{"colspan":1,"rowspan":1,"colwidth":[258.86]},"content":[{"type":"paragraph","content":[{"text":"Contrary to #12 use ","type":"text"},{"text":"0-size","type":"text","marks":[{"type":"strong"}]},{"text":"-arrays when converting collection using ","type":"text"},{"text":"Collection.","type":"text","marks":[{"type":"code"}]},{"text":"toArray","type":"text","marks":[{"type":"code"}]},{"text":"()","type":"text","marks":[{"type":"code"}]},{"type":"hardBreak"},{"text":"See ","type":"text"},{"text":"this article","type":"text","marks":[{"type":"link","attrs":{"href":"https://www.baeldung.com/java-collection-toarray-methods"}}]},{"text":" for explanation","type":"text"}]}]},{"type":"tableCell","attrs":{"colspan":1,"background":"#ffebe6","rowspan":1,"colwidth":[565.15]},"content":[{"type":"paragraph","content":[{"text":"void processNames(Collection names) {","type":"text","marks":[{"type":"code"}]},{"type":"hardBreak"},{"text":" String[] namesAsArray =","type":"text","marks":[{"type":"code"}]},{"type":"hardBreak"},{"text":" ","type":"text","marks":[{"type":"code"}]},{"text":" ","type":"text","marks":[{"type":"code"}]},{"text":"collection.toArray(","type":"text","marks":[{"type":"code"}]},{"text":"new","type":"text","marks":[{"type":"code"}]},{"text":" ","type":"text","marks":[{"type":"code"}]},{"text":"String","type":"text","marks":[{"type":"code"}]},{"text":"[names","type":"text","marks":[{"type":"code"}]},{"text":".size()","type":"text","marks":[{"type":"code"}]},{"text":"]);","type":"text","marks":[{"type":"code"}]}]}]},{"type":"tableCell","attrs":{"colspan":1,"background":"#e3fcef","rowspan":1,"colwidth":[680.74]},"content":[{"type":"paragraph","content":[{"text":"void processNames(Collection names) {","type":"text","marks":[{"type":"code"}]},{"type":"hardBreak"},{"text":" String[] namesAsArray =","type":"text","marks":[{"type":"code"}]},{"type":"hardBreak"},{"text":" ","type":"text","marks":[{"type":"code"}]},{"text":" ","type":"text","marks":[{"type":"code"}]},{"text":"collection.toArray(","type":"text","marks":[{"type":"code"}]},{"text":"new","type":"text","marks":[{"type":"code"}]},{"text":" ","type":"text","marks":[{"type":"code"}]},{"text":"String","type":"text","marks":[{"type":"code"}]},{"text":"[0","type":"text","marks":[{"type":"code"}]},{"text":"]);","type":"text","marks":[{"type":"code"}]}]}]}]},{"type":"tableRow","content":[{"type":"tableCell","attrs":{"colspan":1,"rowspan":1,"colwidth":[258.86]},"content":[{"type":"paragraph","content":[{"text":"Use 'entry' when iterating over a Map.","type":"text"},{"text":"entrySet()","type":"text","marks":[{"type":"strong"}]},{"text":". And name key and value immediately","type":"text"}]}]},{"type":"tableCell","attrs":{"colspan":1,"background":"#ffebe6","rowspan":1,"colwidth":[565.15]},"content":[{"type":"paragraph","content":[{"text":"trustLevelPerDmiPlugin.entrySet().forEach(trustLevel -> {","type":"text","marks":[{"type":"code"}]},{"type":"hardBreak"},{"text":" doSomething(trustLevel.getKey(), trustLevel.getValue());","type":"text","marks":[{"type":"code"}]},{"type":"hardBreak"},{"text":"}","type":"text","marks":[{"type":"code"}]}]}]},{"type":"tableCell","attrs":{"colspan":1,"background":"#e3fcef","rowspan":1,"colwidth":[680.74]},"content":[{"type":"paragraph","content":[{"text":"trustLevelPerDmiPlugin.entrySet().forEach(entry -> {","type":"text","marks":[{"type":"code"}]},{"type":"hardBreak"},{"text":" String dmi = entry.getKey();","type":"text","marks":[{"type":"code"}]},{"type":"hardBreak"},{"text":" TrustLevel trustLevel = entry.getValue();","type":"text","marks":[{"type":"code"}]},{"type":"hardBreak"},{"text":" doSomething(dmi, trustLevel);","type":"text","marks":[{"type":"code"}]},{"type":"hardBreak"},{"text":"}","type":"text","marks":[{"type":"code"}]}]}]}]},{"type":"tableRow","content":[{"type":"tableCell","attrs":{"colspan":1,"rowspan":1,"colwidth":[258.86]},"content":[{"type":"paragraph","content":[{"text":"Use ","type":"text"},{"text":"@Service","type":"text","marks":[{"type":"strong"}]},{"text":" (org.springframework.stereotype) when a class includes operations.","type":"text"},{"type":"hardBreak"},{"text":"Use ","type":"text"},{"text":"@Component","type":"text","marks":[{"type":"strong"}]},{"text":" when it is a data object only.","type":"text"}]}]},{"type":"tableCell","attrs":{"colspan":1,"background":"#ffebe6","rowspan":1,"colwidth":[565.15]},"content":[{"type":"paragraph","content":[{"text":"@Component","type":"text","marks":[{"type":"code"}]},{"type":"hardBreak"},{"text":"public class TrustLevelManager {","type":"text","marks":[{"type":"code"}]},{"type":"hardBreak"},{"text":" void handleInitialRegistration(...)","type":"text","marks":[{"type":"code"}]},{"type":"hardBreak"},{"text":" { ... };","type":"text","marks":[{"type":"code"}]},{"type":"hardBreak"},{"text":" }","type":"text","marks":[{"type":"code"}]}]}]},{"type":"tableCell","attrs":{"colspan":1,"background":"#e3fcef","rowspan":1,"colwidth":[680.74]},"content":[{"type":"paragraph","content":[{"text":"@Service","type":"text","marks":[{"type":"code"}]},{"type":"hardBreak"},{"text":"public class TrustLevelManager {","type":"text","marks":[{"type":"code"}]},{"type":"hardBreak"},{"text":" void handleInitialRegistration(...)","type":"text","marks":[{"type":"code"}]},{"type":"hardBreak"},{"text":" { ... };","type":"text","marks":[{"type":"code"}]},{"type":"hardBreak"},{"text":"}","type":"text","marks":[{"type":"code"}]}]}]}]}]},{"type":"paragraph"},{"type":"heading","attrs":{"level":2},"content":[{"text":"Groovy & Spock Conventions","type":"text"}]},{"type":"paragraph","content":[{"text":"See ","type":"text"},{"text":"Groovy & Spock Test Code Conventions","type":"text","marks":[{"type":"link","attrs":{"href":"https://lf-onap.atlassian.net/wiki/spaces/DW/pages/16447567"}}]}]}],"version":1}