You are viewing an old version of this page. View the current version.
Compare with Current
View Page History
« Previous
Version 16
Next »
CPS-1016
-
Getting issue details...
STATUS
Assumptions/Decisions
# | Issue | Notes/Jira | Decsion |
---|
1 |
|
|
|
2 |
|
|
|
3 |
|
|
|
Merge 2 'query' end points in one
# | Layer | Proposed Changes |
---|
1 | REST Layer | - openapi.yaml
- change /v1/data/ch/searches to /v1/ch/id-searches
- ncmp.yaml
- change queryCmHandles method to executeCmHandleIdSearch
- Use the CmHandleQueryRestParameters schema to both of them
- components.yaml
- merge schema to CmHandleQueryRestParameters schema
- delete Conditions schema
|
2 | Controller Layer | - NetworkCmProxyController
- Update controller methods to use the new schema
- Both component method call separated service method
- Rename queryCmHandles method to executeCmHandleIdSearch
|
3 | Service Layer | - NetworkCmProxyDataService
- Create new method for query cmHandles
- Keep queryCmHandles method and rename it to queryCmHandleIds
- Both method should be calling separate methods in CpsDataService
- Validation logic should be moved to an separated method and call it from both method
- CpsDataService
- Update queryCmHandles method return type to Set<CmHandles>
- Use separate methods to CmHandlesId search to just return a collection of CmHandleIds (extract from DataNode Objects)
- CpsAdminPersistenceService
- Update queryCmHandles will always return complet DatNode object(s). No updates can be done
|
4 | Persistence Layer | - ModuleReferenceQuery
- Update queryCmHandles method return type to Set<CmHandles>
- Update queryCmHandles method to handle both filtering parameters
- Create to separete method for CmHandlesId searches with new filtering parameters (use the original queryCmHandles method code)
|
Test
- update existing tests to the new endpoint (groovy and CSIT)
- create new tests for new filtering scenarios (combine the two existing filter) in CSIT tests
References