Skip to end of metadata
Go to start of metadata

You are viewing an old version of this page. View the current version.

Compare with Current View Page History

« Previous Version 13 Next »


CPS-1016 - Getting issue details... STATUS


Assumptions/Decisions

#

Issue

Notes/Jira

Decsion

1


2


3



Implementation Proposal

Merge 2 'query' end points in one

#LayerProposed Changes
1REST Layer
  • openapi.yaml
    • change /v1/data/ch/searches to  /v1/ch/id-searches
  • ncmp.yaml
    • change queryCmHandles method to executeCmHandleIdSearch
    • Use the CmHandleQueryRestParameters schema to both of them
  • components.yaml
    • merge Conditions schema to CmHandleQueryRestParameters schema
2Controller Layer
  • NetworkCmProxyController
    • Update controller methods to use the new schema
    • Both component method call separated service method
    • Rename queryCmHandles method to executeCmHandleIdSearch
3Service Layer
  • NetworkCmProxyDataService
    • Create new method for query cmHandles
    • Keep queryCmHandles method and rename it to queryCmHandleIds
    • Both method should be called a same method in CpsAdminService
    • Validation logic should be moved to an separated method and call it from both method
  • CpsAdminService
    • Update queryCmHandles method return type to Set<CmHandles>
    • Use separate methods to CmHandlesId search
  • CpsAdminPersistenceService
    • Update queryCmHandles method return type to Set<CmHandles>
    • Use separate methods to CmHandlesId search
4Persistence Layer
  • ModuleReferenceQuery
    • Update queryCmHandles method return type to Set<CmHandles>
    • Update queryCmHandles method to handle both filtering parameters
    • Create to separete method for CmHandles and CmHandlesId searches


Test

  • update existing test to the new endpoint
  • create new tests for new filtering scenarios (combine the two existing filter) CSIT tests


References


  • No labels