Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

as a committer in the SDC project we will all use the flowing set of guide lines for reviewing incoming commits

  1. did the code pass compilation and unit tests successfully? (Jenkins +1)
  2. Does the commit massage explained the commit clearly.
  3. does the attached Jire item provides the needed clarification
  4. do all the files have the license header?
  5. does the code matches the standard? (need to elaborate)