Versions Compared

Old Version 1

changes.mady.by.user Joseph Keenan

Saved on

compared with

New Version 2

changes.mady.by.user Toine Siebelink

Saved on

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

Info
  • Submitters should be pro-active getting their work reviewed
  • Work-Item Owner (WIO) definitely should review related commits
  • Submitter should always self-review before submitting to gerrit.onap (use IntelliJ history view or Nodix commit)
  • Aspects to review
    • Functional/AC -> WIO
    • Technical/quality. Anyone should be able to
  • not Not all coders need to get involved in all reviews, this could be counter productive
    • Ideally about 4 reviewers in total
      • Scenario  A
        • CoderSubmitter
        • Work Item owner
        • + 2 additional reviewers
      • Scenario  B
        • Coder Submitter = Work Item Owner
        • Other Senior developer
        • + 2 additional reviewers
  • Others can view of course , maybe alert blocking issues. But preferably focus on more relvant relevant commit reviews
  • See also Committer Best Practices

...