Page Comparison

Table of Contents

Jira Legacy

server	System Jira
columnIds	issuekey,summary,issuetype,created,updated,duedate,assignee,reporter,priority,status,resolution
columns	key,summary,type,created,updated,due,assignee,reporter,priority,status,resolution
serverId	4733707d-2057-3a0f-ae5e-4fd8aff50176
key	CPS-731

Scope

It should be able to query all cm handles with a given set of public cm handle properties.

Requirements

We want all cm-Handles where both things are true.
If name is empty silently ignore, if value is empty (edge case test?)
Those properties also need to exist.
If query body does not follow supported structure return 400.
Empty query will return all cm-Handles.

A/C:

...

Table of Contents

Jira Legacy

server	System Jira
columnIds	issuekey,summary,issuetype,created,updated,duedate,assignee,reporter,priority,status,resolution
columns	key,summary,type,created,updated,due,assignee,reporter,priority,status,resolution
serverId	4733707d-2057-3a0f-ae5e-4fd8aff50176
key	CPS-731

Scope

...

It should be able to query all cm handles with a given set of public cm handle properties.

Requirements

We want all cm-Handles where both things are true.
If name is empty silently ignore, if value is empty (edge case test?)
Those properties also need to exist.
If query body does not follow supported structure return 400.
Empty query will return all cm-Handles.

A/C:

Demo - with "and" behavior
CI Test - two attributes

...

Issue

Notes

Decision

1

Does request body need to declare "publicCmHandleProperties"?

Do we need to explicitly declare "publicCmHandleProperties"?

Will there be another possible variation to this in the future?

Code Block

language	yml

{
  "publicCmHandleProperties" : {
          "Colour": "red",
          "Size": "large"
   }
}

Yes

2

Are public properties always stored (in postgress) in the format of "name" : x, "value": y?

(does NOT affect implementation)

In the fragment table there are example that follow this format

Code Block

language	yml

{
	"name": "Colour",
	"value": "red"
},
{
	"name": "Size",
	"value": "large"
}

Yes. But all this is hidden when using CpsPath type query

3

Will there only ever be 1 kv pairs in public properties (in the DB)?

Yes, as each property is stored in a separate list-item Fragment
But all this is hidden when using CpsPath type query

4

Does the order matter?

Does

Code Block

language	yml

{
  "publicCmHandleProperties" : {
          "Colour" : "green",
          "Size" : "small"
   }
}

==

Code Block

language	yml

{
  "publicCmHandleProperties" : {
          "Size" : "small"
          "Colour" : "green",
     }
}

No
But all this is hidden when using CpsPath type query

5

Should search be case sensitive?

depend on CPSPath functionality - may be case-sensitive

https://docs.onap.org/projects/onap-cps/en/latest/cps-path.html

Yes, that is the currently implement as such CpsPath type query. Given it is mostly machine-to-machine type queries this is good enough and performs better

6

What format should the response take?

We have two options currently:

Return List<String>

Code Block

language	yml

[
    "cmHandle1",
    "cmHandle2",
    ...,
    "cmHandleN"
]

2. Return CM Handle Objects

1. Already defined in CPS
2. <Example Pending>

Contact Tony Finnerty & kieran mccarthy regarding this.
Tony Finnerty Has no opinion on this matter

It has been decided to implement this using a list of cm handles

7

what if we have valid entries and one entry is empty?

We would return all cm handles and others that match would be included in this list anyway.

→ To avoid this should we first check the entries int map for empty entries as further processing is unnecessary in this case.

Discussed with Toine Siebelink and implementation changes are required for handling edges cases. we will handle empty and unknown properties separately.

8

Regarding empty/missing property in request

e.g.

{

    "publicCmHandleProperties": {
        "": "doesnt matter "
    }
}

Do we want to throw an exception if there is an empty property?

Do we silently ignore them and move on?

should we send two lists back... one with matching cm handles and one with those that failed processing?

We will throw a DataValidationException if an entry contains an empty property

...

#

URI

Design Notes

Comment(s)

1

POST /ncmp/v1/data/ch/searches

Scenario : Request received to return all cm handles matching properties given
Method : POST
URI : {ncmpRoot}/ncmp/v1/data/ch/searches
Header : Content-Type: application/json

Request Body

Code Block

language	yml

{
  "publicCmHandleProperties" : {
     "Colour" : "green",
     "Size" : "small"
   }
}

Response Body Example 1

Code Block

language	yml

[
	"cmHandle1",
	"cmHandle2",
	...,
	"cmHandleN"
]

...

Code Block

language	yml
title	Sample OpenAPI yAML
collapse	true

executeSearchForMatchingPublicProperties:
  post:
    description: Execute search to get all cm handles for the given public properties
    tags:
      - network-cm-proxy
    summary: Execute cm handle search using
    operationId: executeSearchForMatchingPublicProperties
    requestBody:
      required: true
      content:
        application/json:
          schema:
            $ref: 'components.yaml#/components/schemas/PublicProperties'
    responses:
      200:
        description: OK
        content:
          application/json:
            schema:
              type: array
              items:
                type: string
      400:
        $ref: 'components.yaml#/components/responses/BadRequest'
      items401:
                type: string$ref: 'components.yaml#/components/responses/Unauthorized'
      400403:
        $ref: 'components.yaml#/components/responses/BadRequestForbidden'
      401404:
        $ref: 'components.yaml#/components/responses/UnauthorizedNotFound'
      403500:
        $ref: 'components.yaml#/components/responses/Forbidden'
      404:
        $ref: 'components.yaml#/components/responses/NotFound'
      500:
        $ref: 'components.yaml#/components/responses/InternalServerError'

Testing

Data Used for Testing

Image Removed

URL Used for all Requessts

http://localhost:8883/ncmp/v1/data/ch/searches

Results - Happy Path

...

.yaml#/components/responses/InternalServerError'

Testing

...

Data Used for Testing

Image Added

URL Used for all Requessts

http://localhost:8883/ncmp/v1/data/ch/searches

Results - Happy Path

No properties given

(Return CM Handles that Match which contain public properties

#

Scenario

Request

Response

1

Both properties match

(Return CM Handles that Match)

{
    "publicCmHandleProperties": {
        "Contact": "newemailforstore@bookstore.com"
    }
}

[
"Bookstore1",
"PNFDemo"
]

2

No properties given

(Return CM Handles that Match which contain public properties)

{

"publicCmHandleProperties": {
}
}

[
    "Bookstore4",
    "Bookstore5",
    "Bookstore1",
    "Bookstore2",
    "Bookstore3",
    "PNFDemo"
]

3

Multiple Entries - both properties match

(Return CM Handles that Match)

{
    "publicCmHandleProperties": {
        "Contact": "newemailforstore@bookstore.com",
        "color" : "red"
    }
}

[
    "Bookstore1",
    "Bookstore3",
    "PNFDemo"
]

2

Results - Edge Cases

}
}

#

Scenario

Request

Response

1

Value doesn't match

(Nothing Returned)

{
"publicCmHandleProperties": {

[
    "Bookstore4",
    "Bookstore1",
    "Bookstore2",
    "Bookstore3",
    "PNFDemo"
]

3

Multiple Entries - both properties match

(Return CM Handles that Match) "Contact": "wont match"
}
}

[ ]

2

Unknown properties given

(Return Empty Response)

{
"publicCmHandleProperties": {
"

Contact

UnknwnProperty": "

newemailforstore@bookstore.com

doesnt matter"

,

"color" : "red"

}
}

[
    "Bookstore1",
    "Bookstore3",
    "PNFDemo"
]

Results - Edge Cases

Value doesn't match

(Nothing Returned) Empty , "" : "doesnt matter",
"Contact": "newemailforstore@bookstore.com"
400 BADREQUESTInvalid dataMissing property - please supply a valid property

#	Scenario	Request	Response
1	]
3	Empty property (invalid) (BAD_REQUEST)	{ "publicCmHandleProperties": { " Contact ": " wont match doesnt matter " } }	[ ]	2	Unknown properties given (Return Empty Response)	{ "status": "400 BAD_REQUEST", "message": "Invalid data", "details": "Missing property - please supply a valid property" }
4	Empty value (valid) (Return CM Handles Returned that Match)	{ "publicCmHandleProperties": { " UnknwnProperty color": " doesnt matter " } }	[ "Bookstore4" ]	3
5	Multiple entries with one empty property (invalid) (BAD_REQUEST)	{ "publicCmHandleProperties": { "color" : "doesnt matter " } } Empty value (valid) (Return CM Handles Returned that Match) { "status": "400 BAD_REQUEST", "message" : "Invalid datadoesnt matter", "detailsContact": "Missing property - please supply a valid property" }	4	newemailforstore@bookstore.com" } }	{ " publicCmHandleProperties "color status": { "400 BAD_REQUEST", "message": "Invalid data", } "details": "Missing property - please supply a valid property" }	[ "Bookstore4" ]
5	Multiple entries with one empty property (invalid) (BAD_REQUEST)	6	Apostrophe in cm handle (Exception) * CPS can accept a cm handle with an apostrophe but fails to return when queried *	{ "publicCmHandleProperties": { "color" : "won't match"		} }	{ "status": "	500 INTERNAL_SERVER_	ERROR", "message": "	Error while parsing cpsPath expression", "details": "	failed to parse at line 1 due to extraneous input 't' expecting {']', 'and'}" }

Future Example (Out-of-scope)

...

Versions Compared

Old Version 58

New Version 59

Key

Scope

Scope

Testing

Data Used for Testing

Results - Happy Path

Testing

Data Used for Testing

Results - Happy Path

Results - Edge Cases

Results - Edge Cases

Future Example (Out-of-scope)