Jira Legacy | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|
Jira Legacy | ||||||||||
|
...
Code Block | ||||||
---|---|---|---|---|---|---|
| ||||||
module stores { yang-version 1.1; namespace "org:onap:ccsdk:sample"; prefix book-store; revision "2020-09-15" { description "Sample Model"; } typedef year { type uint16 { range "1000..9999"; } } container bookstore { leaf bookstore-name { type string; } list categories { key "code"; leaf code { type string; } leaf name { type string; } list books { key title; leaf title { type string; } leaf lang { type string; } leaf-list authors { type string; } leaf pub_year { type year; } leaf price { type uint64; } }; } } } |
It has been noted that the json content for read and write requests in CPS-Core is inconsistent
...
Response
/Body
...
{
"bookstore":{ "bookstore-name":"Chapters",
"categories":[ ... ]
}
}
...
Solution
...
For the JSON output of Get DataNode we need to alter the DataMapUtils class. The function toDataMap translates a datanode object to a JSON output:
...
}
}
}
}
}
|
It has been noted that the json content for read and write requests in CPS-Core is inconsistent
Description | Response for getDataNode root node | Response for getDataNode non root node | body when writing (root) DataNode |
---|---|---|---|
Operation | GET | GET | POST/PUT |
xPath | / | /bookstore/categories[@code='01'] | / |
Response /Body |
| { } |
|
Notes | The response includes the 'value' of the bookstore node ie. the leaves and children | <= Same | the body needs to include the whole container object. |
Solution
# | Solutions | Issues |
---|---|---|
1 | Use the parent node xpath in order to wrap the queried leaves. eg query xpath = /bookstore/categories[@code='01'] => categories | This should be reasonably straightforward as the node is named after the container name given by the module yang file. |
For the JSON output of Get DataNode we need to alter the DataMapUtils class. The function toDataMap translates a datanode object to a JSON output. We only want this to occur on the top node and as such we can create a new method which is called before toDataMap:
public static Map<String, Object> toDataMapTopNode(final DataNode dataNode) {
final String nodeName = dataNode.getXpath().substring(dataNode.getXpath().lastIndexOf('/') + 1)
.replaceAll("\\[.*?\\]", "");
return ImmutableMap.<String, Object>builder().put(nodeName,
toDataMap(dataNode)
).build();
}
}
We only want the container name on the top level of the JSON output and as such have to distinguish between a top level node and non top level node. We create an outer map to wrap the inner map which creates the appropriate levels in the JSON output.
This produces the following response in the Post Request output:Request output:
Description | Response for getDataNode root node | Response for getDataNode non root node |
---|---|---|
Operation | GET | GET |
xPath | / | /bookstore/categories[@code='01'] |
Response /Body | { |
...
"bookstore": { |
...
[...] } } | { |
...
"name": "SciFi" |
...
, |
...
} } | ||
Notes | Response includes the container bookstore | The response includes the list categories |
---|
Tests would need to be updated to accept the new JSON output which is returned. Examples would need to be updated in openapi
...