Page Comparison

...

cvssv

It has been noted that the json content for read and write requests in CPS-Core is inconsistent

...

For the JSON output of Get DataNode we need to alter the DataMapUtils class. The function toDataMap translates a datanode object to a JSON output:

public static Map<String, Object> toDataMap(final DataNode dataNode) {
    final boolean isTopLevelNode = dataNode.getXpath().lastIndexOf('/') == 0;
    if (isTopLevelNode) {
        String containerName = dataNode.getXpath().substring(1);
        return ImmutableMap.<String, Object>builder().put(containerName,
            ImmutableMap.<String, Object>builder()
                .putAll(dataNode.getLeaves())
                .putAll(listElementsAsMap(dataNode.getChildDataNodes()))
                .putAll(containerElementsAsMap(dataNode.getChildDataNodes()))
                .build()
            ).build();
    } else {
        return ImmutableMap.<String, Object>builder()
            .putAll(dataNode.getLeaves())
            .putAll(listElementsAsMap(dataNode.getChildDataNodes()))
            .putAll(containerElementsAsMap(dataNode.getChildDataNodes()))
            .build();
    }
}

We only want the container name on the top level of the JSON output and as such have to distinguish between a top level node and non top level node. We create an outer map to wrap the inner map which creates the appropriate levels in the JSON output. 

This produces the following response in the Post Request output:

{
    "bookstore": {
        "bookstore-name": "Easons",
        "categories": [
            {
                "code": "01",
                "name": "SciFi"
            }
        ]
    }
}

Tests would need to be updated to accept the new JSON output which is returned. Examples would need to be updated in openapi

...