...
- Understanding of the TOSCA service template is critical.
- Understanding the Commissioning → Instantiation step
- Understanding the relationship between runtime and participants and how control loops and control loop elements relate to each other.
Development Issues
PMSH Use Case
Commissioning
Interaction between Commissioning and Instantiation, possibly using existing CLAMP functionality to bridge between commissioning and instantiation.
Checking and validation
Instantiation
Interaction between Commissioning and Instantiation, possibly using existing CLAMP functionality to bridge between commissioning and instantiation.
Checking and validation
Monitoring
Supervision
Refactoring of handling
Handling of error reports or missed reports from participants
Participants
Participant implementations for DCAE/Policy/CDS
Refactoring Participant as a JAR
GUI
Rough GUI/Client
- Supervision and Monitoring
By Component:
- Commissioning:
- Redefine the API's needed. Exact GET's needed + checks to introduce, What do we actually need?
- Pushing of control loop component definitions to participants? Flow of how you get from a commissioned control loop definition to an instantiated control loop.
- Â Monitoring:
- Monitoring and supervision functionality interchanged. Needs to be updated in the wiki.
- Need to finalize the statistics data for participants and Control loop elements. Also need to decide, if we require to implement association between statistics classes and parent.
- GUI for monitoring?
Considerations
PMSH implementation
Participant implementations for DCAE/Policy/CDS
Using existing CLAMP functionality to bridge between commissioning and instantiation.
Checking and validation
Refactoring Supervision Handling
Refactoring Participant as a JAR
Rough GUI/Client
Design time?
Architecture/Design wiki page, or official documentation?
...
- ?
Decisions
- Stick with the Wiki for documentation and convert to RST later, keep the wiki page up to date. Wiki page should be updated and kept aligned before design start, as component functionality can be agreed among all.
- Set up CSIT tests for the control loop work. Also get some help from experienced people in CSIT.
- Explain the concepts of Control Loops/Participants/Control Loop Elements in a good way with good diagrams and better documentation, also the TOSCA service template and node templates.
- Put up a howto on the Wiki on how to run the demo.
- Training on the Policy Framework and its principles.
- Informal Demos at the standups from everyone of commits coming in, maybe where there are issues!
- Get the Jenkins verify jobs running in Nordix
- Code Reviews
- Follow ONAP guidelines as a minimum Code Review
- Check and perform reviews
- First thing in the morning
- After Lunch
- Last thing in the evening
- Be gentle and kind
- Provide suggestions on changes rather than just saying something is incorrect: Do How as well as What and Why
- Checklist for Code Reviews (Sirisha Manchikanti to champion)
- Code must pass verify job, unverified jobs are not code reviewed
- Checkstyle: Covered by build (Verified commit proves checkstyle is OK)
- Coverage: 80%, Put figure from Eclipse/IntelliJ in the commit message: Investigate how to do in IntelliJ
- Integration Tests done statement
- What Functionality covered statement
- What Functionality is not covered (if needed)
- What the Definition of done for this feature is and how near we are to that
- Wiki page for new joiners, already is a lot of info out there but it's scattered. We should have a landing page for ourselves. Park this and come back
- Jira (Sirisha Manchikanti )
- Jira tickets can be updated with new subtasks, an acceptance criteria defined and agreed per sub-task
- Jira Tickets can be updated with progress and gerrit links, if acceptable.
...