...
In addition to the guidelines specified Committer Best Practices, all DCAE committers are expected to look at these areas before merging a patch. If any item is not followed, you should reply with a -1. Also add comments in appropriate places within the code.
...
Review window
- Avoid same day approval unless change is fixing an broken job or critical bug
- As committers are spread across different timezone, provide atleast 24 hours window before merge for non-critical updates.
- Include other committers (if not already added into review) and primary contributors for reviews
Configure Gerrit watch for auto-notification
- Goto Gerrit→ Settings→Notification to setup auto email alerts to recieve notification on submission into DCAE repository. This will help when submitter miss to add explicitly all the committers for reviews
Check the Commit Message:
- is the JIRA ticket issue related to this fix?
- does either the issue or the commitment message properly describe what is being changed and why?
- For self-release yaml, ensure comment include description of changes/bug fixes introduced in that version. If multiple jira's are consolidated - include all Jira reference/brief summary
Check the License Blocks and Copyright Lines on all code and documentation files
...
- Ensure no outstanding patch remaining in gerrit for review/merge merge for container being released. We would want to avoid releasing container too frequently as well (consider consolidating release for multiple patch)
- As artifiact release impacts different repositories (blueprint/bootstrap, oom etc); consolidate release request (and subsequent update to other impacted repositories)
Review window of atleast 1 day
- Avoid same day approval unless change is fixing an broken job or critical bug
- As committers are spread across different timezone, provide atleast 24 hours window before merge for non-critical updates.
- Include other committers and contributors for repository for reviews For self-release yaml, ensure comment include description of changes/bug fixes introduced in that version. If multiple jira's are consolidated - include all Jira reference/brief summary