Versions Compared

Old Version 6

changes.mady.by.user Dan Timoney

Saved on

compared with

New Version Current

changes.mady.by.user Dan Timoney

Saved on

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

  1. When performing code reviews, committers should note whether check the following items:
    1. Verify that the submission contains appropriate test cases.  If the committer believes this submission could reduce the projects' code coverage, he/she should vote -1 on the submission and add a comment advising the submitter that they need to add appropriate testing.
    2. Verify that the Jira ticket listed in the code submission:
      1. Is appropriate for the code change (for example, verify that the change described fits within the description in the Jira).
      2. Is in either SUBMITTED or IN PROGRESS state
  2. After code is merged, the committer who merged the code should verify that the merge build was successful in Jenkins.
  3. After code is merged, the PTL will review code coverage in Sonar.  If the merge reduces the unit test coverage, the PTL will ask the developer who submitted that change to submit a new change adding appropriate testing.After code is merged, the committer who merged the code should verify that the merge build was successful in Jenkins.