Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

DRAFT PROPOSAL FOR COMMENTS

...

M2 Release Functionality Freeze Milestone definition.



In the middle of a CMR merge to align with integration in https://gerrit.onap.org/r/#/c/78882/

back on this patch in a couple hours





Practice AreaCheckpointYes/NoEvidence - CommentHow to?
Product Management

Are all provisional APIs interface (stub) been defined (at beta-quality level)? 

YesONAP Application Logging Specification v1.2 (Casablanca)#DeveloperGuide


Is there a final list of externally consumable APIs available?YesSLF4J jar - see pom.xml in ONAP Application Logging Specification v1.2 (Casablanca)#pom.xml

For all completed Sprints, have Sprint Backlog Stories been marked as "Done" in Jira?

Yes

Log board

https://jira.onap.org/secure/RapidBoard.jspa?rapidView=143

backlog

https://jira.onap.org/secure/RapidBoard.jspa?rapidView=143&view=planning&selectedIssue=LOG-412&epics=visible

Difference between a Product and Sprint Backlog

Are all tasks associated with the completed Sprint Backlog Stories been marked as "Done" in Jira?

Yes

backlog 

https://jira.onap.org/secure/RapidBoard.jspa?rapidView=143&view=planning&selectedIssue=LOG-412&epics=visible


If applicable to your project, has your team been able to clear the project' blockers? If not provide status on the plan to close the blocker(s).N/A
Link to blockers.
What new features or changes to existing features in this project scope need to be communicated to VNF Providers? List the changes in the Evidence tab.N/A

If yes to the previous question, have these been communicated to the VNF Requirements project? N/A

Release Management

Have all source code files been updated with License Apache 2 header?yes
Specific rules and instruction are available in ONAP wiki.
Has the year format in copyright header of all source code files been updated? (Rules for new files created in 2018 and existing files modified in 2018 are different)Yeschecked all projects in eclipse for 2018, new changes say 2019Guidance on year format
In case source code can't be edited, has a "License.txt" file been placed at the root directory for which the license is applicable?N/Aall source can be editedGuidance for source code file that can't be edited
(a) Has the Project Team added appropriate license and copyright notices to all ONAP source code and documentation files, where possible for the particular file format?Yes

(b) Has the Project Team reviewed and understood the most recent license scan reports from the LF, for both (a) licenses within the codebase and (b) licenses for third-party build time dependencies?Yes

For both (a) and (b) questions, have all high priority non-Project Licenses been either removed, planned for removal before code freeze, or escalated as likely exception requests?Yes

Have all API projects dependencies been captured?

Yes

Provide link to the "API Incoming Dependency" section within your project M1 Release Planning deliverable.

The source of information for the API dependency is the "API Incoming Dependency" of the M1 Release Planning deliverable. Please update the source accordingly, and let The Release Manager aware of the changes.
DevelopmentFor new projects approved for this release, have all defined repositories source code been placed into Gerrit?Yes

Provide link to evidence


For evidences, provide link(s) to Gerrit repos by providing the URL as shown in this example

Example

Has the project team reach the Automated Unit Test Code Coverage expectation? (Refer to artifacts available in Sonar)Yes

Goal: 50% for Incubation project in Beijing

Actual: 84.8 as of 20190220 (down from 88.8)

https://sonar.onap.org/dashboard?id=org.onap.logging-analytics%3Alogging-analytics

84.8%
Coverage

POMBA = 79.2 https://sonar.onap.org/dashboard?id=org.onap.logging-analytics.pomba%3Apomba-audit-common

Guidance on Code Coverage and Static Code Analysis

Tools: Sonar

Is there any binaries (jar, war, tar, gz, gzip, zip files) in Gerrit project repository?No

Addressed draft review containing a zip in https://gerrit.onap.org/r/#/c/57083/2


Team, Gildas, we discussed the zip issue some more - (zip files not allowed in git), we decided that since SDC works with tosca zip files then to fully test our interaction with SDC we need to be able to have zip files available to the testing framework - changing this review off -1 for zip submission Note: we should document this decision for the future when an audit of the code is done - I will send a mail to onap-discuss but it would be good if the javadoc of the testcase explained this zip requirement so we can link to git from the review, jira and release review

Jira Legacy
serverSystem Jira
serverId4733707d-2057-3a0f-ae5e-4fd8aff50176
keyLOG-522

https://gerrit.onap.org/r/#/c/57083/3/src/test/resources/toscaModel.csar.zip,unified

Refer to CI Development Best Practices
Could you ensure that all proprietary trademarks, logos, product names, company name, etc. have been removed? All ONAP deliverables must comply with this rule and be agnostic of any proprietary symbols.Yes

Addressed draft review containing an AT&T logo in https://gerrit.onap.org/r/#/c/57211/1



Is there any pending commit request older than 36 business hours in Gerrit?Yeshttps://gerrit.onap.org/r/#/q/status:open+logging
Have all the Jenkins jobs successfully passed (Merge-Jobs)?Yes

Provide link as evidence to Jenkins project tab

https://jenkins.onap.org/view/logging-analytics/

Any failing jobs are due to lack of seed code


Are all snapshot binaries available in Nexus?Yes

Provide link to evidence in Nexus project folder

1.2.2

https://nexus.onap.org/service/local/repositories/snapshots/content/org/onap/logging-analytics/


Integration and Testing  Have functional test cases been documented in wiki?Yes

Provide link to evidence

RI jar/war/docker/kubernetes-pod exercising the ELK stack via rest endpoint - ONAP Application Logging Specification v1.2 (Casablanca)#LoggingResults


Have you implemented in Jenkins at least 1 functional test case for each of the project repository?No

As an evidence, provide a link to Jenkins (CSIT Jobs) that shows a sample test case implemented (1 job for each repo).

AOP WAR wrapper for functional test case - https://git.onap.org/logging-analytics/tree/reference/logging-demo

docker image build for FT - https://git.onap.org/logging-analytics/tree/reference/logging-docker-root/logging-docker-demo

kubernetes helm chart for FT- https://git.onap.org/logging-analytics/tree/reference/logging-kubernetes - in review (includes filebeat stack) - https://gerrit.onap.org/r/#/c/57171/


As an example (provided by Integration Team)


Has the project code successfully passed the Build process?Yeshttps://jenkins.onap.org/view/logging-analytics/job/logging-analytics-master-verify-java/

Goal is to ensure your project latest commits have not broken the build.

DocumentationHas the team identified and outlined the set of documentations to be delivered in this Release?YesLogging Casablanca Scope
SecurityHas the Release Security/Vulnerability table been updated in the   protected Security Vulnerabilities wiki space?
Table in in the protected Security Vulnerabilities wiki space   corresponding to the latest NexusIQ scanPTL reviews the NexusIQ scans for their project repos and fills out   the vulnerability review table

Have all project containers been designed to run as a non-root user?

 https://wiki.onap.org/display/DW/Best+Practices

  • The Docker and Kubernetes engines may run as root until such time as the products support non-root execution.
  • Applications may run as root within a container.
  • The process ID of a container must not run as the root ID with the exception of containers supporting ONAP features that require the container to run as the root ID.
  • Containers may run with root privileges.
  • Project containers that run as the root ID must document this in the release notes along with the functionality that requires the container to run as the root ID.

...