...
- Code Coverage needs to be improved to 50% - require TechM and IBM resources to commit for the plan
- SDK repo - Naveen is working on new SDK code coverage changes. New SDK commits made - Please add more reviewers ("Amrita Kundu" <amrkundu@in.ibm.com> and Mani are working part time on the code coverage - Saravanan to check with resources to mostly work on Javascript tests).
- Prasad/Swapnali - Please use Epic - PORTAL-268 - for code coverage - PORTAL-273; for sonar issues - PORTAL-247; (focused on Portal repo).
- Portal's Javascript unit test plan? Yes it should be done in Casablanca- Prasad/Swapnali (Manoop to followup with TSC on the requirement on JS code coverage), Karma - look into it (Yatindra looking into it) plugin like jacoco
- Code Coverage: recommendation from TSC is to keep 50% Code Coverage for Casablanca including JavaScript. (In Beijing Release code coverage was only covering Java and Python code)
EclEmma - https://www.eclemma.org/ Java Code Coverage for Eclipse
- Design for Angular update - Saravanan to provide the Design review and plan; listed out items, testing one screen, needs a week for this , another week for design document
Portal Admin screen - for POC to migrate to latest Angular - Saravanan(Design discussion to understand the impact - Thurs 05/31).Meeting minutes:
- Advantages of upgrade:
- Rich UI, performance (quick UI response 5x better than older version), optimization (helps to move away from bower as it is deprecated)
- Internationalization support
- Easy development in latest version compared 1.4 version – with typescript multiple IDE support to compilation error in angular JS code reduces the development time
- JavaScript unit test coverage (analyzing, if we can reuse the Karma existing tests)
- could help security aspect – (analyzing)
- Estimates: 81 (Dev), 16 (Unit testing), 20 (Integration testing) days for 1 resource
- Check if IBM can have one more resource to work on this task (Saravanan to check)
- Request TechM resources to contribute, if they are interested (check in the next Portal scrum)
- Based on current analysis, it is possible to maintain both Angular version 1 and latest. We can try SDK support both versions but needs to figure out a plan to convert the SDK.
- Should we support both versions in same SDK or switch SDK completely to latest version and only do critical patches to older SDK? Will partnering apps upgrade ever to latest SDK?
- Advantages of upgrade:
- fonts and icons abstraction so that they can be switched with a flag configuration - Saravanan (decided to achieve this configuration during the build rather than at runtime).
- Working session to be scheduled to discuss on the changes on SDK - Saravanan
- Source code to be committed for Angular upgrade in a separate folder under SDK .(waiting on fixing the build process which is taking long)
- Lorraine to run grep scan for ecomp keyword - done - Review with Sunder/Manoop - will send them result in email - forward scan email to Hima and Lorraine
- Look for the vm host names in the files - to clean up - Lorraine already made commit for this changes - Hima can help if requires java file changes.
- ECOMP to ONAP word changes in license text - done in Code Cloud - waiting to move to Gerrit - 08/01
- Need to review the MUSIC related classes to cleanup the ECOMP keywords.
Design to be scheduled for Simplify etc/hosts, OOM and AAF changes - Sunder (forward to Ritesh Nadkarni and team too)Leimeng to schedule the AAF review session for Casablanca changesVID, SDC, Policy agreed to keep the both http and https endpoints.
Status on AAI role adding in T-Lab - Leimeng/Hector (Hector to schedule a working session with Arul and Leimeng)- Moving the current CSIT tests to test-suites repo - may need to create a new JIRA item to track
- Sireesh to plan the test cases for the new features planned to Casablanca - Portal R3 Casablanca Functional Test Cases
Prepare M2 Functionality Freeze checklist - Leimeng- Sireesh/Saravanan to followup with Sitharam for resources on AAF - CADI risk in Portal.
- Logging standards analysis done by Lorraine - link to the expected changes for logging - ONAP Application Logging Specification v1.2 (Casablanca)
- Micheal O Brien reviewing the logging changes that can be done in portal/sdk - followup
- Review the current MDCs in the "EPEELFLoggerAdvice.java" class and others that might have.
Attendees:
Discussion Items:
- Internationalization language support plan for Casablanca - PORTAL-267 - (Tao Shen shentao@chinamobile.com)
- Tao is updating the API definition at appropriate documentation in wiki and rst files.
- Choose language/internal components
In discussion by larger community (Use Case UI Team), expecting implementation details (Leimeng to followup)Leimeng has sent email to Tao Shen shentao@chinamobile.com on this topic and iswaiing frwaitng for his return emailView file name multi-language(20180618).pptx height 250
- Testing
- CSIT test for new Casablanca features - Sunder to schedule a session to go over the new features.
- Convert ECOMP selenium tests into CSIT ONAP Robot Framework tests - Sunder/Sireesh - Sunder to provide the ECOMP test scripts to Sireesh.
- Enable JavaScript Unit tests. (How will this impact the angular upgrade? Will these unit tests work as is even after upgrade?).
- Code Coverage needs to be maintained at 50% on both portal and portal/sdk repos without JS coverage.
- Reporting feature enhancement in portal/sdk -
- Sundar RJira Legacy server System Jira serverId 4733707d-2057-3a0f-ae5e-4fd8aff50176 key OOM-1143 - Defect fixes (Hima looking into items)
...