...
Analysis of the onap/ecomp issue in MSO with the ELK stack raised by Borislav |
---|
A lot of the fixes since Dec 30 were done during the 3 day blitz to stabilize ONAP in prep of KubeCon and the F2F - during validating the vFW If you look at some of the merges – we might get hammered on being light on reviewers for master – but you would need to know this was a cherry picked form 1.1 where the fixes were done first - and tested on 2 systems –which does have all the reviewers . The issue is a lack of regression testing for logs. We need to have a plan to address changes that are approved but still cause design contention and are raised later – in the logging meeting the issue is phrased more of a design refactor issue not something that is actually fully broken - again need to retest the MSO logs - which we can now that vf-module creation works because of Alexis de Talhouët https://gerrit.onap.org/r/#/q/status:merged+project:+oom For example https://gerrit.onap.org/r/#/c/25053/ was flagged as busted – but reviewed as ok because a separate patch reverted the onap/onap back to onap/ecomp for filebeat/logback the fix https://gerrit.onap.org/r/#/c/25219/1 fixed this issue and was signed off – if we are talking about another change then we may need to create a new JIRA for it when we identify it I will add an agenda item to the OOM meeting tomorrow to get this ongoing issue resolved – as in identify exactly the issue in a JIRA and add all reviewers before we adjust the yamls again –and get Borislav’s signoff. Which brings up the fact that we likely need to consume public onap daily and run a log sanity on it asap – especially after a large number of commits and between the port to master. We need a process for this before being put into integration testing after the F2F. |
- additional