Page Comparison

We have a serious issue where committers are merging their own code - with no review or oversight.

"After a committer gave you +2" should not be "After you gave you a +2"

I might be missing something but this automated check put into place in oct has no effect

https://lists.onap.org/pipermail/onap-discuss/2017-October/005982.html

https://lists.onap.org/pipermail/onap-discuss/2017-October/005832.html

I have tried to keep this low level - but if we are held to rigid deadlines like these teams - we need a level playfield and not an effective 2 tier system.

Analogy 1

those that drive in either the left or right lane

those that just ignore the yellow line and create 3 lanes out of 2

Analogy 2

Those that use the exit lane on the highway only to exit

Those that use the exit lane as an evolutionary advantage to jump the queue and merge back in at a higher position

Q) are those of us following the rules actually doing the right thing in the long run?

projects I have run into are integration, vfc, sdc - I am not targetting these projects - as these are just the ones I have run into so far

This is wrong for several reasons and several of us have raised this in the discuss groups for a while

reviews are meant to share changes

reviews can be incremental so that other developers can consume work in progress

reviews catch potential issues with integrating the change inside and outside the particular onap component.

If we don't enforce the 2 rules that the rest of us are bound by - then those that follow the rules are in a significant disadvantage - for example I would like to merge a script - I need to put it through rigourous review by 5-10 developers over the course of a couple days - If i am working on parallel work that is on top of this commit in progress - then I need to resolve merge conflicts later - this all takes time - time that we could put to working on release details/artifacts

rule 2 - second company - ideally we collaborate between organizations this way

For the developers that just merge their own code and skip both the rules - they can have very high throughput.

Exceptions: there have been some when critical fixes needed to get in to restore the build (we don't have proper CD E2E integration testing yet) - perhaps even these exceptions should not occur.

some more history on this ongoing issue

Avi

The LF

see

and